Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example notebook on Binder #6306

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Update example notebook on Binder #6306

merged 2 commits into from
Mar 11, 2022
+24 −33

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 10, 2022

Remove previous references to RetroLab in the example.ipynb used to demo the interface on Binder.

@jtpio jtpio added this to the 7.0 milestone Mar 10, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/example-binder

krassowski
krassowski reviewed Mar 10, 2022
View reviewed changes
binder/example.ipynb Outdated Show resolved Hide resolved
@jtpio @krassowski
Update binder/example.ipynb
c6b86aa 
Co-authored-by: Michał Krassowski <[email protected]>
krassowski
krassowski approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtpio jtpio merged commit 7eb29f0 into jupyter:main Mar 11, 2022
@jtpio jtpio deleted the example-binder branch March 11, 2022 07:28
@jtpio
Copy link
Member Author

jtpio commented Mar 11, 2022

Thanks @krassowski for the review!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
documentation status:resolved-locked
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @krassowski