fixed UserMenu alignment #6565
Merged
fixed UserMenu alignment #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Still needs a label i am not able to add one. @jtpio |
|
Thanks @Mieju. Trying with the Binder link above, the menu still looks a bit off:
Also we'll probably want to move the user menu CSS to this file since it appears on all pages: https://github.com/jupyter/notebook/blob/main/packages/application-extension/style/base.css |
|
Okay, I will look into it. 👍 |
|
I think i fixed it. @jtpio |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to align the UserMenu and complete the Issue.
Happy Hacktoberfest! :)
Fixes #6555