Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on nbclassic 0.4.7 #6593

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Oct 20, 2022

This PR upgrades the nbclassic dependency to 0.4.7.

@echarles echarles added the dependencies Pull requests that update a dependency file label Oct 20, 2022
@bnavigator
Copy link
Contributor

Just wanted to let you know that from a distribution point of view this pinning and bumping out of sync is really annoying.

@echarles
Copy link
Member Author

@bnavigator thx for your feedback. We have today a community call (https://github.com/jupyter/notebook-team-compass) where we can discuss that. You are welcome to join, or share here more context (why, conseqences, alternatives...)

@echarles
Copy link
Member Author

We have discussed that during the community call and the conclusion was that we should define a lower boundary instead of a strict pin. I have just pushed a commit that defines nbclassic>=0.4.7

@bnavigator
Copy link
Contributor

Thank you. I understand that sometimes it is necessary, e.g. the pinning to 0.4.5 because 0.4.6 broke it (#6580) But when you do, please at least add a comment and explain it in your commits/pull requests. For example, #6570 is unnecessarily opaque.

@echarles
Copy link
Member Author

Right, I have added a small explanation on #6570 (comment)

@RRosio
Copy link
Collaborator

RRosio commented Oct 28, 2022

LGTM, thanks @echarles!

@RRosio RRosio merged commit 8a00144 into jupyter:6.5.x Oct 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants