Clean up interface switcher plugin in preparation for release

[afshin]

This PR makes the INotebookTracker required instead of checking for it at runtime. It also adds an ellipsis … character to the interface button/dropdown to indicate it is a two-step UI control.

[github-actions]

👈 Launch a Binder on branch afshin/notebook/interface-switcher

[afshin]

bot please update playwright snapshots

[jtpio]

Thanks @afshin.

It also adds an ellipsis … character to the interface button/dropdown to indicate it is a two-step UI control.

Maybe we could use the same caret icon as in the file browser for the "New" dropdown?

notebook/packages/tree-extension/src/index.ts

Lines 86 to 89 in 072a5d6

	const menubar = new MenuBar(overflowOptions);
	const newMenu = new Menu({ commands });
	newMenu.title.label = trans.__('New');
	newMenu.title.icon = caretDownIcon;

[afshin]

That's a good idea for consistency.

[afshin]

bot please update playwright snapshots

[jtpio]

Kicking CI.

[jtpio]

The snapshot update shows that the label is now slightly higher:

Maybe we could try to re-align it like it was before, but this could also be done in a follow-up PR.

[afshin]

bot please update playwright snapshots

[jtpio]

Looks like there were no changes to push when updating the snapshots? https://github.com/jupyter/notebook/actions/runs/4405807628/jobs/7717182164

[afshin]

Chromium fails but Firefox passes ... do the snapshots only come from Firefox?

I visually can confirm my changes are visible in Chrome.

[jtpio]

do the snapshots only come from Firefox?

No it's for both chromium and firefox. We can try again.

[jtpio]

bot please update playwright snapshots

[jtpio]

I visually can confirm my changes are visible in Chrome.

hmm the snapshot update still doesn't pick them up. I also tried building this branch in a fresh environment and this is what it looks like in Firefox (not aligned with the kernel name):

[afshin]

bot please update playwright snapshots

[jtpio]

Thanks!