Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of the default factory in the URL #6873

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix handling of the default factory in the URL #6873

merged 1 commit into from
May 16, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 16, 2023

Fix handling of default factory in the URL so it does not show up anymore when opening a file from the file browser with the default factory.

Before

image

After

image

@jtpio jtpio added the bug label May 16, 2023
@jtpio jtpio added this to the 7.0 milestone May 16, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/factory-url

@jtpio jtpio marked this pull request as ready for review May 16, 2023 08:38
@jtpio jtpio changed the title Fix handling of default factory in the URL Fix handling of the default factory in the URL May 16, 2023
@jtpio jtpio merged commit e976dfd into jupyter:main May 16, 2023
@jtpio jtpio deleted the factory-url branch May 16, 2023 08:48
@jtpio jtpio mentioned this pull request May 24, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jtpio jtpio

Labels
bug
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jtpio