-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require importlib_resources for testing on Python < 3.10 #7016
Conversation
1349450
to
879803b
Compare
Now that it is testing on different Python versions, 3.12 fails on a deprecation warning which is out of the scope of this PR:
|
fail-fast: false | ||
matrix: | ||
# used by the jupyterlab/maintainer-tools base-setup action | ||
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test on all Python versions? Or maybe the lowest and highest versions (and 3.12) would be enough, like here?
notebook/.github/workflows/build.yml
Line 121 in 76db867
python: ['3.8', '3.11', '3.12'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly to help reduce the number of CI jobs if they are not strictly necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you, but #7014 would not have been caught by your proposed set of pythons:
There was
importlib-resources>=5.0;python_version<\"3.9\"",
and the failure was only with Python 3.9. For 3.8 we already have the backport and for python 3.10 the included stdlib is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok then we can keep all versions and see how it goes with CI over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #7014
importlib.resources is only used in the tests. Version 5.0 is included in python 3.10+