-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt sp-repo-review #7039
Adopt sp-repo-review #7039
Conversation
notebook/templates/edit.html
Outdated
{% endblock %} | ||
</head> | ||
<body data-notebook="edit"> | ||
{# Copy so we do not modify the page_config with updates. #} {% set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we might want to keep the previous line breaks here for readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adopt pypi.org/project/sp-repo-review, which has a standard set of checks for packages in the scientific python ecosystem, as seen in learn.scientific-python.org/development.