Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Binder environment #7059

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update Binder environment #7059

merged 1 commit into from
Sep 19, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 18, 2023

  • Remove the JupyterLab 3 dependency, as jupyterlab is installed as a dependency of notebook.
  • Bump ipywidgets
  • Bump nodejs

@jtpio jtpio added this to the 7.0.x milestone Sep 18, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/update-binder

andrii-i
andrii-i approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binder link works reliably and builds successfully every time I try.

blink1073
blink1073 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtpio jtpio merged commit 2b4b422 into jupyter:main Sep 19, 2023
31 of 32 checks passed
@jtpio jtpio deleted the update-binder branch September 19, 2023 05:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrii-i andrii-i andrii-i approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees

@jtpio jtpio

Labels
maintenance
Projects
None yet
Milestone
7.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jtpio @blink1073 @andrii-i