maint: refactor __init__.py and add _version.py, drop setup.py, require python 3.7+
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
changed the title
consideRatio
force-pushed
the
pr/refactor-version
branch
from
55667fd
to
c3fb5e7
Compare
consideRatio
force-pushed
the
pr/refactor-version
branch
from
c3fb5e7
to
9f37846
Compare
minrk
reviewed
Dec 6, 2022
|
|
||
| return setup(app, *args, **kwargs) | ||
| from ._version import __version__ # noqa | ||
| from .autodoc_traits import ConfigurableDocumenter, TraitDocumenter, setup # noqa |
There was a problem hiding this comment.
I think there's actually no reason to have more than just one autodoc_traits.py (no directory at all) for a single-purpose package like this, what do you think?
There was a problem hiding this comment.
Makes sense, could I go for it in a standalone PR?
consideRatio
changed the title
__init__.py and add _version.py, drop setup.py, require python 3.7+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this makes sense, but I figure I can get down to adding some tests before concluding that with certainty.
Is it breaking to drop support for python 3.6 and require python 3.7 when it has reached end of life?