Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changelog.md, release.md, README badges #7

Merged
merged 4 commits into from
Mar 15, 2022
Merged

add changelog.md, release.md, README badges #7

merged 4 commits into from
Mar 15, 2022

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 22, 2021

closes #6

@minrk minrk mentioned this pull request Oct 22, 2021
Closed
6 tasks
consideRatio
consideRatio reviewed Oct 22, 2021
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
consideRatio
consideRatio approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a single detail - go for merge on resolution of that!

@yuvipanda
Copy link
Contributor

bump?

@consideRatio consideRatio added the documentation Improvements or additions to documentation label Mar 15, 2022
@minrk
Copy link
Member Author

minrk commented Mar 15, 2022

Apparently I had published 0.1.0 when I made this PR, so it's already up. Sorry! Not sure if that was a mistake or not.

I simplified the release steps to use tbump.

consideRatio
consideRatio approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah then this should be fine to merge right away i figure. Lets cut 1.0.0 as the nextno matter what i think.

@yuvipanda yuvipanda merged commit d618d9e into jupyterhub:main Mar 15, 2022
@yuvipanda
Copy link
Contributor

MERGE!

@minrk minrk deleted the release-doc branch March 15, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda left review comments

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release automation
3 participants
@minrk @yuvipanda @consideRatio