Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature proposal] Add toleration "hub.jupyter.org/dedicated=user:NoSchedule" to build pods #851

Closed
jhamman opened this issue May 22, 2019 · 0 comments · Fixed by #853
Closed

Comments

@jhamman
Copy link

jhamman commented May 22, 2019

I'd like to propose adding a default toleration to binderhub build pods. In most cases, build pods are intended to be scheduled on the same nodes as user notebook sessions so I think the easiest path forward would be to match the jupyterhub taint/toleration for users:

hub.jupyter.org/dedicated=user:NoSchedule

My motivation is that I'd like to restrict scheduling on my user node-pool to only build and notebook pods.

Adding a toleration does not require a matching taint be set, rather it allows the cluster manager to set taints that certain pods can tolerate. For this reason, I don't immediately see any downside to this feature being added. That said, I'm still learning in this space so I'm open to redirection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant