Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default toleration to build pods #853

Merged
merged 1 commit into from
May 23, 2019
Merged

add default toleration to build pods #853

merged 1 commit into from
May 23, 2019

Conversation

jhamman
Copy link

@jhamman jhamman commented May 23, 2019

This implements a minimally invasive addition to the build pod spec, adding a default tolerations to build pods that match zero2jupyterhub.

hub.jupyter.org/dedicated=user:NoSchedule

cc @consideRatio

closes #851

@betatim
Copy link
Member

betatim commented May 23, 2019

LGTM and tests seem happy. Merging now, if this turns out to be controversial we can always revert it.

@betatim betatim merged commit 4209b9e into jupyterhub:master May 23, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request May 23, 2019
@jhamman
Copy link
Author

jhamman commented May 23, 2019

Thanks @betatim - I'll push this to Pangeo's binder and report any problems.

@consideRatio
Copy link
Member

Is a build pods task to build a single image? Then i think this is really good!

@consideRatio
Copy link
Member

Hmmmm, one may consider using the custom user scheduler as well then btw, if not, they will stop scale downs unless there is 0 build pods for ten full minutes.

@jhamman
Copy link
Author

jhamman commented May 23, 2019

Is a build pods task to build a single image? Then i think this is really good!

Yes, the build pod builds a single image. In my view, this is ideally done on the same node the notebook will be run, as it provides a higher likelihood that we can avoid a pull of the recently built image. I think there is still an element of chance here so some additional scheduling could help.

one may consider using the custom user scheduler as well then btw

This sounds like a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature proposal] Add toleration "hub.jupyter.org/dedicated=user:NoSchedule" to build pods
4 participants