-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify image-cleaner handling #1588
Simplify image-cleaner handling #1588
Conversation
664674e
to
745465c
Compare
This patch refactors the creation and handling of the image cleaner daemonset. The current behaviour makes it so that if one doesn't disable the host cleaner explicitly when using dind (or pink), they would end up with two cleaners instead of one. The new behaviour avoids this issue by ensuring that only the container matching the selected imageBuilderType is created. Same goes for the volumes handling. In order to have consistent naming, the "local" imageBuilderType enumeration value is replaced with "host". It also deprecates the use of the imageCleaner.host.enabled parameter as you either want image cleanup or not.
They are part of the builder object, not the daemonset.
745465c
to
4ccecaa
Compare
I've marked this as breaking since it should be considered in conjunction with #1531 so they're best treated as one larger change. |
One practical question for |
For this repo- not at the moment. I'm inclined to not specify the version since the current advice is to always run the latest main branch (this is what we do in https://github.com/jupyterhub/mybinder.org-deploy) so. You could perhaps link to the relevant PR(s) instead? There's more ongoing refactoring (such as #1318 #1521) but when the repo is more stable we could consider a 1.0.0 release but that's a separate discussion! |
helm-chart/binderhub/templates/container-builder/daemonset.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added a commit changing a comment and updating syntax.
jupyterhub/binderhub#1588 Merge pull request #1588 from sgaist/refactor_image_cleaner_handling
This is a follow up of #1531.
This patch refactors the creation and handling of the image cleaner daemonset.
The current behaviour makes it so that if one doesn't disable the host cleaner explicitly when using dind (or pink), they would end up with two cleaners instead of one.
The new behaviour avoids this issue by ensuring that only the container matching the selected imageBuilderType is created. Same goes for the volumes handling.
In order to have consistent naming, the "local" imageBuilderType enumeration value is replaced with "host".
It also deprecates the use of the imageCleaner.host.enabled parameter as you either want image cleanup or not.