Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing buildOnly param to the server from the js client #1742

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

yuvipanda
Copy link
Collaborator

@yuvipanda yuvipanda commented Sep 15, 2023

Update of js client with the feature developed in #1647

yuvipanda added a commit to yuvipanda/jupyterhub-fancy-profiles that referenced this pull request Sep 15, 2023
- Also construct URL to binder dynamically, assumed to be under
  /services/binder on the same host
- Use a submodule to bring in latest version of the binderhub-client
  for now, as things move fast. Currently at jupyterhub/binderhub#1742
@consideRatio consideRatio added code:js-binderhub-client js changes to binderhub-client maintenance Under the hood improvements and fixes labels Oct 10, 2023
@yuvipanda yuvipanda marked this pull request as ready for review October 12, 2023 14:55
@consideRatio consideRatio merged commit e67edb0 into jupyterhub:main Oct 12, 2023
13 of 15 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:js-binderhub-client js changes to binderhub-client maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants