JS: Fix some JSDoc types, and misc details in tests #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
added
maintenance
- Optional args get [] around the param name, not the type! - Remove extra increased timeout for some jest tests, as they are not needed - Pass actual URL objects to some of the methods, rather than strings. These accidentally worked but shouldn't be relied upon. - Import just the function used during tests from node modules, rather than the entire module. - Fix type of `fetch` to indicate that's actually just an *iterator*, not a *generator*. Ref jupyterhub#774
yuvipanda
force-pushed
the
somemoretypes
branch
from
cec8be2
to
bcae809
Compare
consideRatio
changed the title
consideRatio
changed the title
consideRatio
approved these changes
Oct 22, 2023
|
Amazing work on this @yuvipanda !!!! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 22, 2023
jupyterhub/binderhub#1783 Merge pull request #1783 from yuvipanda/somemoretypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchto indicate that's actually just an iterator, not a generator.Ref #774