Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base_url into livenessProbe.httpGet.path #775

Merged
merged 1 commit into from
Jan 24, 2019
Merged

add base_url into livenessProbe.httpGet.path #775

merged 1 commit into from
Jan 24, 2019

Conversation

bitnik
Copy link
Collaborator

@bitnik bitnik commented Jan 24, 2019

Liveness probe fails with 404 when base_url is set for BinderHub. So I added base_url into livenessProbe.httpGet.path if base_url is set, default is "/".

@betatim
Copy link
Member

betatim commented Jan 24, 2019

Thanks for catching this. Different base_urls haven't penetrated my brain enough yet that I remember this :)

Restarted travis.

@betatim betatim merged commit 710c3d7 into jupyterhub:master Jan 24, 2019
@betatim
Copy link
Member

betatim commented Jan 24, 2019

Merged!

yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 24, 2019
[binderhub] Automatic update for commit 27f6538
1275c44 
jupyterhub/binderhub#775
@choldgraf choldgraf added the maintenance Under the hood improvements and fixes label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitnik @betatim @choldgraf