Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move badge and path functions out of megafile #778

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

captainsafia
Copy link
Collaborator

@captainsafia captainsafia commented Jan 29, 2019

This PR works towards closing #777.

@captainsafia captainsafia changed the title Move out more functions from megafile Move badge and path functions out of megafile Jan 29, 2019
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @captainsafia

@willingc willingc merged commit c622979 into jupyterhub:master Jan 29, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 29, 2019
@choldgraf choldgraf added the maintenance Under the hood improvements and fixes label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.rst badge code is not copy/pasteable
3 participants