[MRG] rename variable and restructure API docs #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
May 25, 2019
betatim
reviewed
May 25, 2019
betatim
reviewed
May 25, 2019
betatim
reviewed
May 25, 2019
betatim
changed the title
|
Thanks for helping out with the docs. I made some small suggestions, otherwise this looks good to me! Let's leave this to stew for a bit to see if someone from a US timezone wants to chime in. If not I'll merge it in a bit. |
see suggestions by @betatim in jupyterhub#860
|
Merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code and the docs at the same time, I was a bit confused by the API endpoint description. Here is a suggestion for a different structure and wording.
The name
provider_prefixnow also matches the respective parameter name in the API function in the code.Let me know what you think!