Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow standard --no-build prefix for disabling builds #110

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 7, 2020

--no-$feature is a standard format for disabling something on a CLI, so allow this form in addition to the existing --skip-build.

I've typed chartpress --no-build so many times at this point, I thought I might as well make it work :)

`--no-$feature` is a standard format for disabling something,
so allow this form in addition to the existing `--skip-build`
@consideRatio
Copy link
Member

This LGTM - can you do do a README.md update of chartpress --help output also?

@consideRatio consideRatio added the enhancement New feature or request label Dec 14, 2020
@consideRatio consideRatio merged commit 42ecde6 into jupyterhub:master Dec 14, 2020
@consideRatio
Copy link
Member

consideRatio commented Dec 14, 2020

Released and made available as part of 1.0.3. I made it not cause a minor version bump as it was just a new alias of an existing feature rather than an entirely new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants