Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve quote formatting for image tags also #115

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jan 19, 2021

This PR in practice reverts #16 which was introduced due to a bug fixed in ruamel.yaml 0.15.44. For more details see #113, but the gist of it is that there is a difference between ruamel.yaml version 0.15.43 and 0.15.44 that makes us no longer need a previously added workaround to manage the 0.15.43 behavior.

pip install "ruamel.yaml==0.15.43" && \
python -c "import sys; import ruamel.yaml; ruamel.yaml.YAML(typ='rt').dump({'x': '008'}, sys.stdout)"
        
pip install "ruamel.yaml==0.15.44" && \
python -c "import sys; import ruamel.yaml; ruamel.yaml.YAML(typ='rt').dump({'x': '008'}, sys.stdout)"

Closes #113

Motivation

@manics and I are working to setup pre-commit to autoformat yaml files, and chartpress coercing the image tags to single quotes for no good reason is disruptive for us. See jupyterhub/zero-to-jupyterhub-k8s#1996 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No preservation of quote formatting in values.yaml (Chart.yaml is okay)
2 participants