Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extra options to be passed to docker build #142

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Allow extra options to be passed to docker build #142

merged 6 commits into from
Mar 23, 2022

Commits on Dec 31, 2021

  1. Allow extra options to be passed to docker build 

    jupyterhub#141
    @adamblake
    adamblake committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    f637091 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Change extraOptions to extraBuildCommandOptions; accept strings 

    - Use more explicitly named key extraBuildCommandOptions to more clearly
  convey what the key will do
- Update README with example usage
- Change extraBuildCommandOptions to accept a list of strings
- Add tests
    @adamblake
    adamblake committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    ca98ac4 View commit details
    Browse the repository at this point in the history

  2. Fix docs and comments referencing dict in extraBuildCommandOptions 

    The options should be a list of strings now; dicts are not allowed.
    @adamblake
    adamblake committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    bc441d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Merge branch 'main' into adamblake/main

    @consideRatio
    consideRatio committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    a8adc75 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Apply suggestions from code review

    @consideRatio
    consideRatio authored Mar 23, 2022
    Configuration menu
    Copy the full SHA
    77e2c73 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @consideRatio
    consideRatio authored Mar 23, 2022
    Configuration menu
    Copy the full SHA
    3bed6da View commit details
    Browse the repository at this point in the history