chartPath: Chart directory can be different from the chart name
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Nice, this looks great - with the following details, this is approved!
- Title to mention
chartPath - Readme's configuration header to mention chartPath
This is a Helm 3 feature helm/helm#1979 (should we drop Helm 2 instead of having a conditional test?)
I think this is fine, but its also fine to drop support for helm2 - its ancient atm.
manics
changed the title
chartPath: Chart directory can be different from the chart name
|
Done! Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to organise charts in a git repo, for example the chart could be under
PROJECT-NAME/helm-chartinstead ofPROJECT-NAME/helm-chart/PROJECT-NAME, whilst still keeping chartpress.yaml at the root of the repository.This is a Helm 3 feature helm/helm#1979 (should we drop Helm 2 instead of having a conditional test?)