Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Chart.yaml's version to a valid value #54

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Reset Chart.yaml's version to a valid value #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ charts:
# the prefix to use for built images
imagePrefix: jupyterhub/k8s-
# tag to use when resetting the chart values
# with --reset command-line option (defaults to "set-by-chartpress")
# with the --reset flag. It defaults to "set-by-chartpress".
resetTag: latest
# version to use when resetting the Chart.yaml's version field with the
# --reset flag. It defaults to "0.0.1-set.by.chartpress". This is a valid
# SemVer 2 version, which is required for a helm lint command to succeed.
resetVersion: 1.2.3
# the git repo whose gh-pages contains the charts
repo:
git: jupyterhub/helm-chart
Expand Down
2 changes: 1 addition & 1 deletion chartpress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def main():
# requirement on the version field.
chart_version = chart_version.lstrip('v')
if args.reset:
chart_version = chart.get('resetTag', 'set-by-chartpress')
chart_version = chart.get('resetVersion', '0.0.1-set.by.chartpress')
chart_version = build_chart(chart['name'], paths=chart_paths, version=chart_version)

if 'images' in chart:
Expand Down