Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --commit-range #55

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 17, 2019

I want to deprecate this flag as is ignored currently by chartpress.py. I made it a soft deprecation where a warning is printed when --commit-range is used. I also removed the unused path_touched(*paths, commit_range) function.

$ chartpress --skip-build --commit-range test
Warning: use of --commit-range is deprecated.
$> git log -n 1 --pretty=format:%h -- .
$> git describe --tags --long e3d7223f
$> git log -n 1 --pretty=format:%h -- images/hub chartpress.yaml
$> git log -n 1 --pretty=format:%h -- images/network-tools chartpress.yaml
$> git log -n 1 --pretty=format:%h -- images/image-awaiter chartpress.yaml
$> git log -n 1 --pretty=format:%h -- images/singleuser-sample chartpress.yaml
Updating jupyterhub/values.yaml: hub.image: {'repository': 'jupyterhub/k8s-hub', 'tag': '0.9.0-alpha.1_2-e3d7223f'}
Updating jupyterhub/values.yaml: singleuser.networkTools.image: {'repository': 'jupyterhub/k8s-network-tools', 'tag': '0.9.0-alpha.1_0-320470f1'}
Updating jupyterhub/values.yaml: prePuller.hook.image: {'repository': 'jupyterhub/k8s-image-awaiter', 'tag': '0.9.0-alpha.1_0-320470f1'}
Updating jupyterhub/values.yaml: singleuser.image: {'repository': 'jupyterhub/k8s-singleuser-sample', 'tag': '0.9.0-alpha.1_0-320470f1'}

Closes #48


Thank you @alzix for sharing the gist to deprecate an argparse argument!

❤️ 🌻

The new logic is to look in the git history, find the latest commit that
modified an image, create a tag based on this, and see if has been built
already.

Thank you @alzix for sharing the gist to deprecate an argparse argument!

:heart: :sunflower:

ref: https://gist.github.com/alzix/4868d66115a55567d3b43b32742f6f4f
@consideRatio consideRatio merged commit 0ffda22 into jupyterhub:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--commit-range ignored, needs documentation update
1 participant