--long flag to always output build information in image tags and chart version #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
long-version-flag
branch
from
47aacb6
to
2486d5d
Compare
consideRatio
force-pushed
the
long-version-flag
branch
from
2486d5d
to
5e6d960
Compare
consideRatio
force-pushed
the
long-version-flag
branch
10 times, most recently
from
ef19d2a
to
985d9c1
Compare
consideRatio
force-pushed
the
long-version-flag
branch
from
985d9c1
to
27ca781
Compare
14 tasks
|
It would be useful to be able to review PRs, especially before publishing releases if there aren't critical blocking issues in a broken release. |
|
Thanks for telling me, I need the feedback. Sorry for this, chartpress is due to my actions now in a bad state, caused technically by #62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--longflag to always output build information in image tags and chart version. This mimicsgit describe --longthat has does something very similar.The
--longflag could be useful to avoid producing duplicate entries when a build job is run twice, once because of a commit was pushed, and once again because of a tag was pushed and coupled with this commit. If--longus used with pushed commits, but not for pushed tags or with--tag, then we wouldn't risk pushing two charts of the same version for example.