Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs: index merge, image tag, g prefix, ignored tags #64

Merged
merged 8 commits into from
Oct 22, 2019

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 21, 2019

Key issue fixed: index merge

Closes #62 that followed an issue introduced by #52 by implementing #62 (comment) and catching some past mistakes of mine along the way. Fixing #62 is urgent as chartpress 0.4.2 is breaking expected functionality of chartpress.

Additional issues fixed

  • image tag: Found and fixed a bug from Pre-release replaced by later builds #62 relating to the use of - instead of . as separator for image tags, which was not according to plan or inline documentation.
  • g prefix: Stripped away a "g" prefix that follows from use of git describe.
  • Ignored tags: Fixed lacking ability to handle tags after latest modification commit, and renamed function to reflect this.

Other

  • Deleted a remnant function of past logic: last_modified_date(*paths).
  • Added pytest tests for simple to test functions _get_identifier and _strip_identifiers_build_suffix

@consideRatio consideRatio changed the title Fix bugs: index merge, image tag, g prefix [WIP] Fix bugs: index merge, image tag, g prefix Oct 21, 2019
Copy link
Member Author

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes to self

  • refactor the now chart/image common logic into a function.
  • create a function to identify build section and strip it, and stop sending two return values in a tuple as i started doing in this PR

We failed to update the chart version or image tag if there was a git
tag more recent that the latest modifying commit. This commit fixes
that.
@consideRatio consideRatio changed the title [WIP] Fix bugs: index merge, image tag, g prefix Fix bugs: index merge, image tag, g prefix Oct 21, 2019
@consideRatio consideRatio changed the title Fix bugs: index merge, image tag, g prefix Fix bugs: index merge, image tag, g prefix, ignored tags Oct 21, 2019
@minrk
Copy link
Member

minrk commented Oct 22, 2019

Excellent!

@consideRatio
Copy link
Member Author

consideRatio commented Oct 22, 2019

@minrk I had documented in the travis script that rebuilds shouldn't be triggered on running chartpress on z2jh, but it is currently doing that. This is because of the changed image tags that are not yet pushed (7927c93).

@minrk minrk merged commit 203f37d into jupyterhub:master Oct 22, 2019
@minrk
Copy link
Member

minrk commented Oct 22, 2019

Not sure if it was this PR or not, but I'm getting the same effective last-changed commit on all images, regardless of when the image's files were last changed.

@consideRatio
Copy link
Member Author

f41990c - this is probably the relevant change commit.

@consideRatio consideRatio deleted the fix-helm-index-merges-bug branch October 22, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release replaced by later builds
2 participants