-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix build info with n and h to ensure SemVer 2 validity to solve Helm 3 compatibility #87
Conversation
Arg, that's really annoying. These are getting really long, so maybe replace |
Yes, very long, :/ Im afraid of the one letter solution, as that would masquerade it into the hash. Git use Im okay with various options, perhaps even more okay with accepting bad luck can happen and writing out |
Consistency is more important than what looks nice. If the value can sometimes be I don't think Any of |
Yeah, agreed that validity is most important. It’s just frustrating since human intelligibility was the primary motivation that started this whole change, and it’s starting to look a lot less human-friendly in the end. Let’s go with just ‘h’ and release. |
Anyone wanting to replace the |
I started replacing |
14f44dc
to
8b5a05b
Compare
Thanks @betatim for the attempt! I'm home now at my computer and stepped through the commits and made a rebased update. |
I made a 0.6.0 release with this! |
Fixes #86 with 14f44dc + test updates.
In short, we now make
0.9.0-alpha.1.095.123asdf
become0.9.0-alpha.1.n095.h123asdf
to ensure we never have a numerical identifier with a leading zero, which is breaking Helm 3 usage of our chart because its dependency masterminds/semver now does a better job verifying if the version is a valid semver version etc.I failed to spot the suggested version with a leading zero in a fully numerical identifier wasn't a valid semver version before =/
This will need a minor version bump for a release, and could once again cause issues from chartpress that @henchc @betatim has helped worked through in the past for binderhub and mybinder.org.