add chartpress --list-images #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of stdout, which would conflict with piped output
output list of images for consumption by other tools
evaluate stderr.fileno() at call time needed for test redirection
|
Thanks, @minrk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputs list of images to stdout. Listing images implies skip-build.
for convenient consumption of the list of images, e.g. to pass to trivy for security scans
To make chartpress output pipeable, send all log messages to stderr instead of stdout, as is standard practice.
I think this closes #94 unless I misunderstood the goal there.
Since this does move prevous output to stderr, if anyone was relying on chartpress stdout, this could be considered a backward-incompatible change. But since our output was not really machine-readable, I'd call this a minor revision.