Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update object_name with current image #466

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

floriandeboissieu
Copy link
Contributor

@floriandeboissieu floriandeboissieu commented Oct 14, 2022

When several images allowed in dockerspawner and template_name is containing {imagename}, it would be expected that the selected image name is used within the object_name. I didn't found a way to do it as object_name is using default image name if not specified.
This fix updates object_name at container start after check_allowed image. It is working at least for the above use case, don't know if it is the best way to do it and if it has other consequences elsewhere. Also, I set the method _object_name_for_current_image as an async method but I am not very familiar with that method type, so here also I am not sure it is needed.

Hopping it can help, many thanks for that package anyway.

update object_name with current image name in template
fix not wanted copy/paste
@welcome
Copy link

welcome bot commented Oct 14, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@minrk
Copy link
Member

minrk commented Sep 18, 2023

Thanks for the PR! Sorry for the long wait.

@minrk minrk merged commit b280cd9 into jupyterhub:main Sep 18, 2023
9 of 10 checks passed
@welcome
Copy link

welcome bot commented Sep 18, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk minrk added the bug label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants