Exclude SpawnProgressAPIHandler from latency metrics #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a long running connection kept open, serving progressbar responses via [EventSource](https://developer.mozilla.org/en-US/docs/Web/API/EventSource). So it can't be treated as a regular HTTP request / response. Getting rid of this unmasks more real problems in hub response latency by removing this noise. Ref 2i2c-org/infrastructure#2127 (comment)
|
Without this change:
With this change:
I think most of the spikes are actually server stops, but regardless, this is an improvement. |
consideRatio
added
bug
|
Wiee nice!! So if we see this, we shouldn't assume the hub pod is overloaded. Hmm... I opened jupyterhub/jupyterhub#4353 reflecting about if we can measure the hub as overburdened in another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a long running connection kept open, serving progressbar responses via
EventSource. So it can't be treated as a regular HTTP request / response.
Getting rid of this unmasks more real problems in hub response latency by removing this noise.
Ref 2i2c-org/infrastructure#2127 (comment)