Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kerberos Local Authenticator #6

Merged
merged 3 commits into from
Jun 28, 2019

Conversation

dvalters
Copy link
Contributor

@dvalters dvalters commented Jun 28, 2019

Supports creating local system user accounts on login to a jupyterhub server. (In a similar fix to: jupyterhub/ldapauthenticator#36, for LDAPAuthenticator.)

Closes #5

To use the feature, these options are added/changed in the jupyterhub_config.py file:

c.JupyterHub.authenticator_class = 'kerberosauthenticator.KerberosLocalAuthenticator'
c.LocalAuthenticator.create_system_users = True

@jcrist
Copy link
Member

jcrist commented Jun 28, 2019

Would you mind adding this to the docs? Would just need to add another line with this class to docs/source/options.rst.

Configuration Options
=====================

.. autoconfigurable:: kerberosauthenticator.KerberosAuthenticator

.. autoconfigurable:: kerberosauthenticator.KerberosLocalAuthenticator

@jcrist
Copy link
Member

jcrist commented Jun 28, 2019

Looks like the tests aren't passing due to changes to JupyterHub's testing infrastructure in the latest release (had a similar problem in https://github.com/jcrist/yarnspawner). Don't worry about the tests, I'll figure those out. Everything else looks good.

@dvalters
Copy link
Contributor Author

Sure, I'll update the docs as well

docs/source/options.rst Outdated Show resolved Hide resolved
@jcrist
Copy link
Member

jcrist commented Jun 28, 2019

Thanks, merging.

@jcrist jcrist merged commit 2cfa6fb into jupyterhub:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating system users
2 participants