-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 3.0.0 #581
Add changelog for 3.0.0 #581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the readthedocs workflow working?
https://jupyterhub-kubespawner--581.org.readthedocs.build/en/581/index.html
is missing several several entries in the left-hand contents bar, compare
with
https://jupyterhub-kubespawner.readthedocs.io/en/latest/
On the other hand https://jupyterhub-kubespawner.readthedocs.io/en/latest/index.html is missing the 2.0 release!
On second thoughts I think the RTD discrepancy is because #575 isn't included in this branch, and RTD presumably builds off the branch not the PR merge commit. Any chance you could rebase this so we can see the final changelog properly? |
7cfe656
to
fc75dd9
Compare
fc75dd9
to
196250d
Compare
I now consider KubeSpawner 3 ready for release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions, otherwise looks fine to release!
Co-authored-by: Simon Li <[email protected]>
I'd like to hold of a bit with the release for these issues/prs that can be resolved relatively easy I think. I'm trying to nudge them towards completion for a day or two and then go unblock again.
safe_name_for_routespec
anddelete_if_exists
#572