Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 3.0.0 #581

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

@consideRatio consideRatio marked this pull request as draft March 10, 2022 13:03
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the readthedocs workflow working?

https://jupyterhub-kubespawner--581.org.readthedocs.build/en/581/index.html
is missing several several entries in the left-hand contents bar, compare
image

with
https://jupyterhub-kubespawner.readthedocs.io/en/latest/
image

On the other hand https://jupyterhub-kubespawner.readthedocs.io/en/latest/index.html is missing the 2.0 release!

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Show resolved Hide resolved
@manics
Copy link
Member

manics commented Mar 10, 2022

On second thoughts I think the RTD discrepancy is because #575 isn't included in this branch, and RTD presumably builds off the branch not the PR merge commit. Any chance you could rebase this so we can see the final changelog properly?

@consideRatio consideRatio marked this pull request as ready for review March 11, 2022 22:03
@consideRatio
Copy link
Member Author

I now consider KubeSpawner 3 ready for release!

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions, otherwise looks fine to release!

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Show resolved Hide resolved
@consideRatio consideRatio merged commit 5c24f8c into jupyterhub:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants