[KubeIngressProxy] breaking: migrate to networking.k8s.io/v1 api for Ingress resources #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
added
bug
KubeIngressProxy
consideRatio
force-pushed
the
pr/kubeingressproxy-ingress-migration
branch
from
26fe479
to
325b79a
Compare
|
@ondave we aren't able to maintain the KubeIngressProxy class very well in general as it is not actively in use by any JupyterHub team member and bundled in this repo and python package for legacy reasons (#568 describes legacy reasons). If you have the capacity, I'd love your review and input regarding this breaking change for users of KubeIngressProxy. |
|
I think v1.19.16 is also OK with this change, although 1.19 is now EOL, and it would make sense to drop support for 1.17-1.19 in line with #599. The PR looks good and works fine on our minikube v1.21.6 test cluster. |
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #597. With the latest release of kubernetes_asyncio version 22 (mapping to k8s 1.22), we had a failure related to outdated k8s API references extensions/v1beta1. This PR makes KubeIngressProxy generate Ingress resources assuming the networking/v1 API for Ingress resources instead.
Someone installing KubeSpawner 3.0.3 that includes this PR for KubeIngressProxy should clean up all the old Ingress resources for user servers, because they will be orphaned going onwards and could cause collisions etc. I encourage people using KubeIngressProxy to help out documenting more detailed migration steps etc - for example as comments in this PR as it will be linked from the changelog.
This pr should be merged after #599 I think, which it currently includes as well.