Merge pull request #222 from manics/npm-if-changed

npm: auto-rebuild dist if js changed
jupyterhub · Nov 3, 2021 · 03d82f3 · 03d82f3
2 parents 634f2be + 343b5d5
commit 03d82f3
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -11,10 +11,11 @@
 ]
 
 # https://github.com/jupyter/jupyter-packaging/blob/0.10.4/README.md#as-a-build-requirement
-jsdeps = npm_builder(build_cmd="webpack")
+# https://github.com/jupyter/jupyter-packaging/blob/0.10.4/jupyter_packaging/setupbase.py#L160-L164
+jsdeps = npm_builder(build_cmd="webpack", build_dir="nbgitpuller/static/dist", source_dir="nbgitpuller/static/js")
 cmdclass = wrap_installers(
     pre_develop=jsdeps, pre_dist=jsdeps,
-    ensured_targets=jstargets, skip_if_exists=jstargets)
+    ensured_targets=jstargets)
 
 # Imports __version__, reference: https://stackoverflow.com/a/24517154/2220152
 ns = {}