Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RELEASE.md, and update release workflow to use PyPI's trusted publisher #59

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

Sheila-nk
Copy link
Collaborator

@Sheila-nk Sheila-nk commented Apr 25, 2023

  • added RELEASE.md file
  • updated PyPI permissions in release.yaml file
  • removed jupyterhub-bot as a maintaniner on PyPI
  • added repo's release.yaml as a trusted publisher on PyPI
  • deleted GitHub Secret pypi_password

Closes #58

@Sheila-nk
Copy link
Collaborator Author

Sheila-nk commented Apr 25, 2023

I also created a release environment in this repository that the workflow will use for publishing. I am not too sure it is necessary since I have not set any protection rules or environment secrets which would be necessary if the repo had maintainers without publishing access, which is currently not the case.

Let me know if this is a standard thing in the organization. Otherwise, I will need to delete the environment and edit the trusted publishers in PyPI to remove the environment name.

Here is the publishing information page:
https://pypi.org/manage/project/pytest-jupyterhub/settings/publishing/

Screenshot 2023-04-25 at 16 24 32

@Sheila-nk Sheila-nk temporarily deployed to release April 25, 2023 13:45 — with GitHub Actions Inactive
@consideRatio consideRatio temporarily deployed to release April 25, 2023 13:48 — with GitHub Actions Inactive
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this LGTM!

I pushed a commit adding this to the changelog so that is done as well, and with that, I think finally we can go for the release!!

If the added commit is okay with you, go for a merge -> release!

@Sheila-nk
Copy link
Collaborator Author

Thanks for opening an issue on this and for reviewing this PR @consideRatio ❤️
Merging this PR now and moving on to releasing this package 🚀

@Sheila-nk Sheila-nk merged commit 21ceca8 into jupyterhub:main Apr 25, 2023
@Sheila-nk Sheila-nk deleted the release-automation branch April 25, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RELEASE.md, and update release workflow to use PyPI's trusted publisher
2 participants