-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master branch to main #1068
Conversation
…m/$1/$2/$3/HEAD/ For `binder-examples/*`, `jupyterlab/jupyterlab-demo`, `norvig/pytudes`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions, but otherwise this LGTM!
.github/workflows/release.yml: uses: pypa/gh-action-pypi-publish@master
This can be @HEAD
as well right?
docs/source/conf.py:# The master toctree document.
docs/source/conf.py:master_doc = "index"
docs/source/conf.py: master_doc,
docs/source/conf.py:man_pages = [(master_doc, "repo2docker", "repo2docker Documentation", [author], 1)]
docs/source/conf.py: master_doc,
root_doc is now an option to master_doc supported by a modern version of sphinx, so setting both is a compatibility strategy for us to use in order to migrate away from master_doc.
# The root toctree document.
root_doc = master_doc = "index"
Thanks, I've updated the Sphinx conf.py. I'm a bit hesistant to change a critical GitHub action to use HEAD without an official statement from the maintainers. We could switch to commit hashes or tags and rely on dependabot to bump them instead, which also means we'd be fully aware of any changes. Alternatively we could switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a build error, but this is 100% documentation so go for it
Thanks @consideRatio. Let's go for it then! I don't have permission to rename the branch. |
Branch renamed! |
Thanks! Do you know who's got access to readthedocs to check the branch name? |
@manics from https://readthedocs.org/projects/repo2docker/ I conclude among others @yuvipanda @choldgraf have access to update the readthedocs to not be coupled to the master branch, but instead to the main branch. Action point for @yuvipanda or @choldgraf:
|
done 👍 |
Following process from jupyterhub/team-compass#412
Actions to take, in order:
master
branch tomain
in GitHub (this should automatically update all PRs)$ git grep master
External action
Sphinx stuff
Versioneer stuff
Explicit handling of
master
External references
I've avoided changing anything under tests since it'll require code review to ensure we don't inadvertently remove a test case.
Versioneer stuff