Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS documentation fixes #1564

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Jan 31, 2020

Fixes #698
It contains a brief note about EC2 instance metadata and aligns code blocks on the same page with commands. It also has some minor additions to conf.py.

@metonymic-smokey
Copy link
Contributor Author

@consideRatio this is a draft PR for #698. Would love your review!

Thanks!

@betatim betatim changed the title AWS documentation fixes [WIP] AWS documentation fixes Feb 2, 2020
@betatim
Copy link
Member

betatim commented Feb 2, 2020

Thanks for working on this and helping keep the docs up-to-date and good looking!

I added the [WIP] tag to the title of the PR to indicate that it is still a draft. Once you are ready for it to be reviewed thoroughly and then merged you can change it to [MRG].

doc/source/conf.py Outdated Show resolved Hide resolved
doc/source/conf.py Outdated Show resolved Hide resolved
@metonymic-smokey
Copy link
Contributor Author

metonymic-smokey commented Feb 16, 2020

@consideRatio are there any more changes you'd like to add before it LGTM?

Thanks!

@consideRatio consideRatio changed the title [WIP] AWS documentation fixes AWS documentation fixes Oct 2, 2020
@consideRatio
Copy link
Member

@metonymic-smokey thank you and sorry for the extremely slow turnaround to get this merged! ❤️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the fact that access to cloud metadata is disabled by default
4 participants