Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete PDBs for hub/proxy deployments that doesn't support HA #1937

Closed
wants to merge 4 commits into from
Closed

Delete PDBs for hub/proxy deployments that doesn't support HA #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1159dad
pdb: for completeness, add disabled by default pdb for autohttps/trae…
consideRatio Dec 10, 2020
f97c3af
pdb: relocate proxy pods pdb config
consideRatio Dec 10, 2020
7ccfd50
pdb: disable pdb for hub/proxy by default
consideRatio Dec 10, 2020
2a9789b
Remove chart PDBs for hub/proxy/autohttps that can't run in HA
consideRatio Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jupyterhub/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,8 @@ directly instead.
{{ "HARD DEPRECATION: singleuser.imagePullSecret has renamed to imagePullSecret" | fail }}
{{- end }}
{{- end }}


{{- if or (hasKey .Values.proxy "pdb") (hasKey .Values.hub "pdb") }}
{{ "DEPRECATION: proxy.pdb and hub.pdb are no longer created as the pods didn't support being run with multiple replicas!" }}
{{- end }}
13 changes: 0 additions & 13 deletions jupyterhub/templates/hub/pdb.yaml
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions jupyterhub/templates/proxy/pdb.yaml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions jupyterhub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ hub:
runAsGroup: 1000
allowPrivilegeEscalation: false
services: {}
pdb:
enabled: true
minAvailable: 1
networkPolicy:
enabled: true
ingress: []
Expand Down Expand Up @@ -254,9 +251,6 @@ proxy:
pullSecrets: []
resources: {}
labels: {}
pdb:
enabled: true
minAvailable: 1
https:
enabled: false
type: letsencrypt
Expand Down
4 changes: 0 additions & 4 deletions tools/templates/lint-and-validate-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ hub:
tests:
apiToken: mocked-api-token
imagePullPolicy: Always
pdb:
enabled: true
networkPolicy:
enabled: true
egress:
Expand Down Expand Up @@ -189,8 +187,6 @@ proxy:
mock-proxy-label: mock
nodeSelector:
mock-proxy-node-selector: mock
pdb:
enabled: true
https:
enabled: true
type: letsencrypt
Expand Down