Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hub.config passthrough and use it for all auth config #1943

Merged
merged 40 commits into from
Jan 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
11e57b9
auth rework: initial work on config transition message
consideRatio Dec 14, 2020
7f2b8d2
auth rework: remove note about hmacauthenticator, 1.0 is released
consideRatio Dec 15, 2020
6e161ab
auth rework: locate under hub.config
consideRatio Dec 17, 2020
936ec21
auth rework: censor values by default
consideRatio Dec 18, 2020
4e6f235
Add Helm template helper to manage null checks
consideRatio Dec 18, 2020
de19992
auth rework: manage auth.state.cryptoKey / JUPYTERHUB_CRYPT_KEY
consideRatio Dec 18, 2020
cb7577b
auth rework: remove old logic in jupyterhub_config.py
consideRatio Dec 18, 2020
4a9115d
auth rework: add new logic in jupyterhub_config.py
consideRatio Dec 19, 2020
cef2be6
auth rework: improve reliability of help text logic
consideRatio Dec 19, 2020
3a6cfc5
auth rework: update docs with new config examples
consideRatio Dec 19, 2020
020c2bd
auth rework: rename censorHelp to safeToShowValues
consideRatio Dec 19, 2020
6468fe1
auth rework: update default values
consideRatio Dec 19, 2020
f365f3b
auth rework: update lint-and-validate values
consideRatio Dec 19, 2020
5d683c3
auth rework: favor base class config
consideRatio Dec 19, 2020
87e5f2a
docs: mv auth .rst to .md
consideRatio Dec 19, 2020
aeaabff
docs: pandoc auth .rst to .md
consideRatio Dec 19, 2020
1c6d59e
docs: corrections of pandoc rst to md transform
consideRatio Dec 19, 2020
c34692e
docs: use schema_ instead of schema: to be markdown link compatible
consideRatio Dec 20, 2020
3763884
docs: use schema_ instead of schema: to be markdown link compatible (2)
consideRatio Dec 20, 2020
c96da70
auth rework: update schema.yaml
consideRatio Dec 20, 2020
cfadab6
auth rework: update authentication docs in guide
consideRatio Dec 20, 2020
a8b343c
auth rework: use global.safeToShowValues to help usage in subcharts
consideRatio Dec 20, 2020
ad16eae
Language improvements
consideRatio Dec 20, 2020
e2b237d
docs: reference oauthenticator's rendered docs instead of github page
consideRatio Dec 21, 2020
7ad41cc
auth rework: avoid using __init__ classname shortcut in oauthenticator
consideRatio Dec 21, 2020
96cb2c3
auth rework: rework of introduction paragraph
consideRatio Dec 21, 2020
2fa641c
auth rework: full pass update of auth docs
consideRatio Dec 21, 2020
b8f8ee8
auth rework: attempt to describe CILogon
consideRatio Dec 21, 2020
5a2d84f
ci: update devenv to automatically rebuild on schema.yaml changes
consideRatio Dec 25, 2020
794d214
auth rework: another full pass of the auth docs
consideRatio Dec 25, 2020
df93c0a
ci: trigger jobs smarter on schema.yaml changes
consideRatio Jan 4, 2021
24e3ce8
docs: add basic hub.baseUrl entry to not make linkcheck fail
consideRatio Jan 4, 2021
4d4eca1
docs: please linkcheck
consideRatio Jan 4, 2021
b19d01b
Apply language suggestions from code review
consideRatio Jan 11, 2021
b740fcf
docs: update authenticator class basics
consideRatio Jan 11, 2021
3610078
docs: add details on provided config example
consideRatio Jan 11, 2021
e0948f9
auth rework: favor XYZOAuthenticator over OAuthenticator
consideRatio Jan 11, 2021
2e3a73a
auth rework: use jupyterhub's built in dummy authenticator
consideRatio Jan 11, 2021
5b0a011
auth rework: final fix for jh embedded dummy authenticator
consideRatio Jan 11, 2021
6c44594
fix CILogon yaml example
minrk Jan 12, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ on:
- "doc/**"
- "**/test-docs.yaml"
- "**.md"
- "**/schema.yaml"
push:
paths-ignore:
- "doc/**"
- "**/test-docs.yaml"
- "**.md"
- "**/schema.yaml"
branches-ignore:
- "dependabot/**"
workflow_dispatch:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ on:
pull_request:
paths:
- "doc/**"
- "**/schema.yaml"
- "**/test-docs.yaml"
push:
paths:
- "doc/**"
- "**/schema.yaml"
- "**/test-docs.yaml"
branches-ignore:
- "dependabot/**"
Expand Down
2 changes: 1 addition & 1 deletion doc/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ help:
# - builds and rebuilds html on changes to source
# - starts a livereload enabled webserver and opens up a browser
devenv:
sphinx-autobuild -b html --open-browser --ignore "*/reference.md" "$(SOURCEDIR)" "$(BUILDDIR)/html" $(SPHINXOPTS)
sphinx-autobuild -b html --open-browser --ignore "*/reference.md" --watch "../jupyterhub/schema.yaml" "$(SOURCEDIR)" "$(BUILDDIR)/html" $(SPHINXOPTS)

# For local development and CI:
# - verifies that links are valid
Expand Down
2 changes: 1 addition & 1 deletion doc/make.bat
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ if errorlevel 9009 (
echo.The 'sphinx-autobuild' command was not found. Open and read README.md!
exit /b 1
)
sphinx-autobuild -b html --open-browser --ignore "*/reference.md" "%SOURCEDIR%" "%BUILDDIR%/html" %SPHINXOPTS%
sphinx-autobuild -b html --open-browser --ignore "*/reference.md" --watch "../jupyterhub/schema.yaml" "%SOURCEDIR%" "%BUILDDIR%/html" %SPHINXOPTS%
goto end


Expand Down
2 changes: 1 addition & 1 deletion doc/source/administrator/advanced.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ The items in this list must be valid kubernetes
### Specifying suitable hub storage

By default, the hub's sqlite-pvc setting will dynamically create a disk to store
the sqlite database. It is possible to {ref}`configure other storage classes <schema:hub.db.type>`
the sqlite database. It is possible to [configure other storage classes](schema_hub.db.type)
under hub.db.pvc, but make sure
to choose one that the hub can write quickly and safely to. Slow or higher
latency storage classes can cause hub operations to lag which may ultimately
Expand Down
Loading