pdb: default to maxUnavailable=1 instead of minAvailable=1 #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/pdb-max-unavailable
branch
from
91530db
to
3df3da3
Compare
yuvipanda
reviewed
Feb 17, 2021
|
So if we have 2 replicas, it will still ensure there will at least be one available, right? |
Yepp! Note btw that maxUnavailable was introduced in k8s 1.9 or something, which was later than the PDBs were introduced in the first place in z2jh. |
|
Hmmmmm, perhaps did a mistake with the logic... It should show maxUnavailable there. Btw, this is from the CI system in the upgrade -> dev step, making a diff on the rendered templates since the last dev release. |
|
Omg, |
consideRatio
force-pushed
the
pr/pdb-max-unavailable
branch
from
a65be2f
to
ce72e8c
Compare
consideRatio
force-pushed
the
pr/pdb-max-unavailable
branch
from
ce72e8c
to
f36ef45
Compare
|
Okay finally got everything right, the tests did a great job helping me! ❤️
|
|
Thanks, @consideRatio! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 18, 2021
jupyterhub/zero-to-jupyterhub-k8s#2039 Merge pull request #2039 from consideRatio/pr/pdb-max-unavailable
|
Thanks @yuvipanda for your help with review/merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to lower the replicas of user-scheduler to 1, then you will get the same PDB issues we have had with hub/proxy (#1938) where they block upgrades etc because we have
minAvailable: 1instead ofmaxUnavailable: 1in order to handle workloads.