Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab ^2.0.0 support #19

Merged
merged 2 commits into from
Mar 10, 2020
Merged

JupyterLab ^2.0.0 support #19

merged 2 commits into from
Mar 10, 2020

Conversation

consideRatio
Copy link
Contributor

Fixes #18

@consideRatio
Copy link
Contributor Author

Note that I also updated the README with a gif animation of the spellchecker in action and made some minor opinionated changes in the text for readability.

ijmbarr
ijmbarr approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@ijmbarr ijmbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ijmbarr ijmbarr merged commit d911bb3 into jupyterlab-contrib:master Mar 10, 2020
@consideRatio
Copy link
Contributor Author

Note i bumped the npm package version also, not sure it made sense for me doing that be part of the PR in retrospect.

@ijmbarr
Copy link
Collaborator

ijmbarr commented Mar 10, 2020

I noticed, don't worry - the fix was enough to deserve it's own release.

@consideRatio consideRatio mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijmbarr ijmbarr ijmbarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JupyterLab 2 compatibility
2 participants
@consideRatio @ijmbarr