Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows #110

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Fix workflows #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f44511
Fix new workflow name
fcollonval Aug 22, 2022
54b7638
Clean up memory leak action
fcollonval Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/actions/memory-leak/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ description: |
Run the JupyterLab memory leak scenarios.

inputs:
# Mandatory inputs
github_token:
description: "The GitHub token to use, must have pull_request:write access"
required: true

# Optional inputs
artifacts_name:
description: "Uploaded memory leak report"
Expand All @@ -21,14 +16,6 @@ inputs:
description: The server URL to wait for (format <hostname:port>)
required: false
default: localhost:8888
git_username:
description: The Git Username to Use for the Commit
required: false
default: github-actions[bot]
git_email:
description: The Git Email to Use for the Commit
required: false
default: github-actions[bot]@users.noreply.github.com

runs:
using: composite
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ permissions:

jobs:
test:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
event: ${{ github.event_name }}
# Repository to clone for scheduled benchmark
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/run-memory-leak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ jobs:
- name: Execute memory leaks test
uses: ./benchmarks/.github/actions/memory-leak
with:
github_token: "FAKE"
server_url: "localhost:9999"

- name: Kill the server
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/scheduled-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# One job per file to deal with the 6hours limit
# jobs.<job-id>.strategy is not allowed for reusable workflow; hence the job duplication
test-codeNotebook:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
# Notebooks to test
tests: '["codeNotebook"]'
Expand All @@ -33,7 +33,7 @@ jobs:
size: '100'

test-mdNotebook:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
# Notebooks to test
tests: '["mdNotebook"]'
Expand All @@ -54,7 +54,7 @@ jobs:
size: '100'

test-longOutput:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
# Notebooks to test
tests: '["longOutput"]'
Expand All @@ -75,7 +75,7 @@ jobs:
size: '100'

test-largeMetadata:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
# Notebooks to test
tests: '["largeMetadata"]'
Expand All @@ -96,7 +96,7 @@ jobs:
size: '100'

test-errorOutputs:
uses: jupyterlab/benchmarks/.github/workflows/run-jupyterlab.yml@master
uses: jupyterlab/benchmarks/.github/workflows/run-benchmark.yml@master
with:
# Notebooks to test
tests: '["errorOutputs"]'
Expand Down