-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI profiler extension #122
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
certain styles as it checks for completer visibility)
- implement table sorting on header click - improve tag count reporting and include in UI summary - improve progress bar for style rule benchmark - fix table not getting updated on result change
Taking it out of draft as all the major bits are in. I will still work on bits and pieces but I do not plan adding anything major in this PR. |
listening to attributes on `:` since `:not(.class)` will result from attribute (class name) change.
`Uncaught TypeError: class constructors must be invoked with 'new'`
Development will continue in https://github.com/jupyterlab/ui-profiler. I will open a new PR integrating jupyterlab-ui-profiler with benchmarks CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of a profiler extension. Implements #119.
Milestones:
and(not very useful)performance gain/#elements
ratioFollow up items (in future PRs):
IScenario
in extensions.