Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions on benchmark #130

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Update actions on benchmark #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b509b2
Update actions on benchmark
fcollonval Jan 30, 2023
e676f8b
Bump actions and base image
fcollonval Jan 30, 2023
9778e5d
Fix Python version
fcollonval Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/run-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ permissions:

jobs:
run-benchmark:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

env:
# Which browser to use (one of 'chromium', 'firefox', 'webkit')
Expand All @@ -92,35 +92,35 @@ jobs:

steps:
- name: Checkout benchmarks project
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: benchmarks

- name: Install node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: "18.x"

- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: "3.10"

- uses: iterative/setup-cml@v1

- name: Cache pip on Linux
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-3.8-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
key: ${{ runner.os }}-pip-3.10-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
restore-keys: |
${{ runner.os }}-pip-3.8
${{ runner.os }}-pip-3.10

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Cache yarn
uses: actions/cache@v1
uses: actions/cache@v3
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
Expand All @@ -131,15 +131,15 @@ jobs:
# First run the benchmark on the reference
- name: Checkout reference branch
if: ${{ inputs.event == 'workflow_dispatch' }}
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: jupyterlab/jupyterlab
ref: ${{ inputs.reference_branch }}
path: reference

- name: Checkout reference branch - schedule
if: ${{ inputs.event == 'schedule' }}
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: ${{ env.CHALLENGER_REPOSITORY }}
ref: ${{ env.CHALLENGER_REF }}
Expand Down Expand Up @@ -303,7 +303,7 @@ jobs:

- name: Publish the report
if: ${{ inputs.event == 'schedule' }}
uses: actions/github-script@v5
uses: actions/github-script@v6
with:
script: |
const fs = require('fs');
Expand All @@ -319,7 +319,7 @@ jobs:

- name: Upload Benchmark Test assets
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifacts_name }}
path: |
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/run-memory-leak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,41 +19,41 @@ on:

jobs:
memory-leak-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

env:
# How many samples to compute
MEMORY_LEAK_NSAMPLES: ${{ inputs.samples }}

steps:
- name: Checkout benchmarks project
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: benchmarks

- name: Install node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: "18.x"

- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: "3.10"

- name: Cache pip on Linux
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-3.8-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
key: ${{ runner.os }}-pip-3.10-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
restore-keys: |
${{ runner.os }}-pip-3.8
${{ runner.os }}-pip-3.10

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Cache yarn
uses: actions/cache@v1
uses: actions/cache@v3
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
Expand All @@ -62,7 +62,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Checkout JupyterLab
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.branch }}
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,41 +8,41 @@ on:

jobs:
test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

env:
# How many times to switch between each tabs
BENCHMARK_SWITCHES: 3

steps:
- name: Checkout benchmarks project
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: benchmarks

- name: Install node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: "18.x"

- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: "3.10"

- name: Cache pip on Linux
uses: actions/cache@v1
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-3.8-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
key: ${{ runner.os }}-pip-3.10-${{ hashFiles('**/requirements.txt', 'setup.cfg') }}
restore-keys: |
${{ runner.os }}-pip-3.8
${{ runner.os }}-pip-3.10

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Cache yarn
uses: actions/cache@v1
uses: actions/cache@v3
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
Expand All @@ -51,7 +51,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Checkout JupyterLab
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: jupyterlab/jupyterlab
ref: master
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:

- name: Upload Test assets
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: test-assets
path: |
Expand Down