New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more experiments #50

Merged

echarles merged 3 commits into jupyterlab:master from datalayer-externals:experiments/cells

Oct 28, 2020

Member

echarles commented Oct 13, 2020

Related to #49

This PR adds some experiments to find the root cause of the performance bottlenecks when displaying a lot of editors.

It implements similar display logic for various editors and measures:

Comparison for `DOMContentLoaded` (seconds) for 1000 editors.

- 1000 JupyterLab Cells: 50 seconds.
- 1000 JupyterLab Cells in a Lumino BoxPanel: 10 seconds for DOMContentLoaded, cells are only shown after 140 seconds.
- 1000 CodeMirrors: 50 seconds.
- 1000 Monaco: 40 seconds for DOMContentLoaded, editors are only shown after 60 seconds.
- 1000 ProseMirror (basic version): 2 seconds.
- 1000 ReMirror: 50 seconds.


          Add more experiments

73267dc

goanpeca reviewed

View reviewed changes

experiments/cell/notebooks/hello.ipynb Outdated

		@@ -0,0 +1,107 @@
		{

Member

goanpeca Oct 13, 2020

Maybe a more descriptive name for the notebook could help?

goanpeca reviewed

View reviewed changes

experiments/cell/src/index.ts Show resolved Hide resolved

goanpeca reviewed

View reviewed changes

experiments/cell/style/index.css Outdated Show resolved Hide resolved

goanpeca reviewed

View reviewed changes

experiments/monaco/README.md Outdated Show resolved Hide resolved

goanpeca reviewed

View reviewed changes

Member

goanpeca left a comment •

edited

Loading

Left a couple of minor comments and a couple of questions. Otherwise looks good. Great work @echarles!


          Fixes based on @goanpeca comments

505d3cd

Member Author

echarles commented Oct 13, 2020

Thx @goanpeca for the reviews. I have pushed fixes for these.


          rename hello.ipynb to example.ipynb

d453de4

echarles commented

View reviewed changes

Member Author

echarles left a comment

LGTM

echarles merged commit 751ca8a into jupyterlab:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet