Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release workflow #39

Merged
merged 7 commits into from
May 20, 2024
Merged

Fix the release workflow #39

merged 7 commits into from
May 20, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented May 20, 2024

This PR adds a script to bump version, inspired from jupyter-collaboration. This script uses lerna to bump (as before), but also bump the root package.json manually.

__ATTEMPT 1: __ This PR remove the version from the root package.json and use the version from lerna.json as the releaser reference version.
This solution avoid treating the root package.json a one of the sub-project: lerna/lerna#2879 (comment) This solution does not work with the releaser with try to run npm pack, which does not work if the version is not specified in package.json.

__ATTEMPT 2: __This PR add the root package.json in workspaces, but excludes the root package from Nx target: lerna/lerna#2879 (comment) With this solution the build-npm step after the bump-version step was broken, it seems that jupyterlab-collaborative-chat and jupyterlab-ws-chat were not build @jupyter/chat anymore (and still depends on it).

@brichet brichet added bug Something isn't working maintenance Packaging, tests and removed bug Something isn't working labels May 20, 2024
@brichet brichet merged commit 0ddd10f into jupyterlab:main May 20, 2024
11 checks passed
@brichet brichet deleted the fix_releaser branch May 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Packaging, tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant