Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to bump version, inspired from
jupyter-collaboration
. This script uses lerna to bump (as before), but also bump the rootpackage.json
manually.__ATTEMPT 1: __
This PR remove the version from the rootpackage.json
and use the version fromlerna.json
as the releaser reference version.This solution avoid treating the rootThis solution does not work with the releaser with try to runpackage.json
a one of the sub-project: lerna/lerna#2879 (comment)npm pack
, which does not work if the version is not specified inpackage.json
.__ATTEMPT 2: __
This PR add the rootWith this solution thepackage.json
in workspaces, but excludes the root package from Nx target: lerna/lerna#2879 (comment)build-npm
step after thebump-version
step was broken, it seems thatjupyterlab-collaborative-chat
andjupyterlab-ws-chat
were not build@jupyter/chat
anymore (and still depends on it).