Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reoganize the project to split typescript packages and extensions #78

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Reoganize the project to split typescript packages and extensions #78

merged 11 commits into from
Sep 12, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Sep 11, 2024

Fixes #72

Reorganizes the project with:

  • a packages directory containing typescript library (@jupyter/chat and jupyterlab-collaborative-chat)
  • a python directory containing jupyterlab extension (jupyterlab_collaborative_chat and jupyterlab_ws_chat)

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/refactor_packages

@brichet brichet changed the title Split jupyter_collaborative_chat fontend package and python extension Reoganize the project to split typescript packages and extensions Sep 11, 2024
@brichet brichet marked this pull request as ready for review September 11, 2024 16:00
jtpio
jtpio approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Just skimmed through the diff, and it looks good.

If CI passes and the releaser assets (built by check-release) look good, then we can probably just go ahead and merge it.

@brichet
Copy link
Collaborator Author

brichet commented Sep 12, 2024

Thanks @jtpio for the review

@brichet brichet merged commit cbe0cdf into jupyterlab:main Sep 12, 2024
10 checks passed
@brichet brichet deleted the refactor_packages branch September 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
collaborative extension maintenance Packaging, tests websocket extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project reoganization
2 participants
@brichet @jtpio