Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI (Backport #221 into 1.x) #224

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Fix CI (Backport #221 into 1.x) #224

merged 6 commits into from
Dec 19, 2023

Conversation

martinRenou
Copy link
Member

  • Remove packageManager entry

  • Fix for Python 3.12

  • Remove use of pytest-asyncio

  • Fix mypy

  • Re-enable Python 3.11

  • Don't test win/py3.12

  • Fix URLs in package.json

  • Update yarn.lock

  • Revert previous commit

  • Remove pip --pre

@davidbrochart @martinRenou
Fix CI (jupyterlab#221)
aa69775 
* Remove packageManager entry

* Fix for Python 3.12

* Remove use of pytest-asyncio

* Fix mypy

* Re-enable Python 3.11

* Don't test win/py3.12

* Fix URLs in package.json

* Update yarn.lock

* Revert previous commit

* Remove pip --pre
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupyter-collaboration/backport_fix_ci

@martinRenou
Copy link
Member Author

Ah Fix License Headers is running from the 1.x branch so it should pass once merged, not before

@davidbrochart
Copy link
Collaborator

Should 99874eb be replaced with #199?

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (1.x@cae6970). Click here to learn what that means.

Additional details and impacted files 
@@          Coverage Diff           @@
##             1.x     #224   +/-   ##
======================================
  Coverage       ?   41.43%           
======================================
  Files          ?        8           
  Lines          ?      572           
  Branches       ?       78           
======================================
  Hits           ?      237           
  Misses         ?      331           
  Partials       ?        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidbrochart
davidbrochart approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbrochart davidbrochart merged commit 6b9986b into jupyterlab:1.x Dec 19, 2023
18 of 19 checks passed
@martinRenou martinRenou deleted the backport_fix_ci branch December 19, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @davidbrochart @codecov-commenter