Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make user's cursor "tooltip-on-hover" faster and wider #259

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Make user's cursor "tooltip-on-hover" faster and wider #259

merged 1 commit into from
Mar 22, 2024

Conversation

jzhang20133
Copy link
Collaborator

@jzhang20133 jzhang20133 commented Mar 22, 2024 •
edited by Zsailer
Loading

When you hover over a user's cursor, it shows their name.

This PR addresses two UX issues around the current behavior:

  1. The width around the cursor where this hover action happens is quite small.
  2. The delay for when the name appears is quite long.

While these are fairly subjective settings, I believe this PR is a better default/minimum for this behavior.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jzhang20133/jupyter-collaboration/main-2

@Zsailer Zsailer changed the title make user name hover show up faster and margin area larger Make user name hover show up faster and margin area larger Mar 22, 2024
@Zsailer Zsailer changed the title Make user name hover show up faster and margin area larger Make user's cursor "tooltip-on-hover" faster and wider Mar 22, 2024
@Zsailer Zsailer added the enhancement New feature or request label Mar 22, 2024
@Zsailer Zsailer mentioned this pull request Mar 22, 2024
Open
ibdafna
ibdafna approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@ibdafna ibdafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Not sure about the units tests - looks unrelated.

@Zsailer
Copy link
Member

Zsailer commented Mar 22, 2024

Thanks @ibdafna.

Yeah, the tests are failing for unrelated reasons. They are failing in all other PRs as well.

@Zsailer Zsailer merged commit 35a515c into jupyterlab:main Mar 22, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibdafna ibdafna ibdafna approved these changes

@Zsailer Zsailer Zsailer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzhang20133 @Zsailer @ibdafna