Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract out ICollaborativeDrive to @jupyter/collaborativedrive #353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract out ICollaborativeDrive to @jupyter/collaborativedrive #353

wants to merge 1 commit into from

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart marked this pull request as draft September 16, 2024 20:25
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/extract-icollaborativedrive

@davidbrochart davidbrochart force-pushed the extract-icollaborativedrive branch 3 times, most recently from cf02af4 to de0c62e Compare September 17, 2024 07:46
@davidbrochart davidbrochart marked this pull request as ready for review September 17, 2024 07:46
@davidbrochart
Copy link
Collaborator Author

Should there be a new projects/jupyter-collaborativedrive?

@davidbrochart davidbrochart mentioned this pull request Sep 17, 2024
Open
@davidbrochart davidbrochart force-pushed the extract-icollaborativedrive branch 6 times, most recently from eb1976f to b0f2621 Compare September 18, 2024 09:19
@davidbrochart
Copy link
Collaborator Author

I'm wondering if this failure:

Error: src/yprovider.ts(6,35): error TS2307: Cannot find module '@jupyter/collaborativedrive' or its corresponding type declarations.
Error: src/ydrive.ts(16,8): error TS2307: Cannot find module '@jupyter/collaborativedrive' or its corresponding type declarations.

is caused by the fact that @jupyter/collaborativedrive is not yet published to NPM?
I cannot reproduce it, it works locally.

@davidbrochart davidbrochart force-pushed the extract-icollaborativedrive branch 2 times, most recently from 711e6cf to 484d489 Compare September 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidbrochart